Skip to content

test: add tests for session not found retries for async runner #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

olavloite
Copy link
Collaborator

Adds tests for SessionNotFound exceptions for AsyncRunner and removes some warnings regarding deprecated methods and possible resource leaks.

@olavloite olavloite requested a review from a team as a code owner October 25, 2020 13:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2020
@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #545 into master will increase coverage by 0.13%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #545      +/-   ##
============================================
+ Coverage     83.79%   83.93%   +0.13%     
- Complexity     2499     2501       +2     
============================================
  Files           141      141              
  Lines         13753    13766      +13     
  Branches       1315     1315              
============================================
+ Hits          11524    11554      +30     
+ Misses         1684     1667      -17     
  Partials        545      545              
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/spanner/SessionPool.java 86.89% <93.75%> (+0.79%) 71.00 <0.00> (ø)
...om/google/cloud/spanner/TransactionRunnerImpl.java 84.27% <0.00%> (+0.23%) 9.00% <0.00%> (ø%)
.../com/google/cloud/spanner/AbstractReadContext.java 86.19% <0.00%> (+3.06%) 53.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddd6ad...835ec7d. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 39b3754 into master Oct 26, 2020
@thiagotnunes thiagotnunes deleted the async-runner-session-retry branch October 26, 2020 03:59
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#3784

Changes:

feat: Publish Dataproc Metastore v1beta API
  PiperOrigin-RevId: 361822828
  Source-Link: googleapis/googleapis@32c7223

feat(metastore): added support for release channels when creating service
  PiperOrigin-RevId: 361819751
  Source-Link: googleapis/googleapis@cd6119f

build: use gapic-generator-typescript v1.2.11.
  Fixed IAM v1 library generation.
  Committer: @alexander-fenster
  PiperOrigin-RevId: 361676678
  Source-Link: googleapis/googleapis@3aeb3a7

chore: upgrade gapic-generator-python to 0.42.2
  PiperOrigin-RevId: 361662015
  Source-Link: googleapis/googleapis@28a5919

docs: Fixed broken links in the reference documentation
  PiperOrigin-RevId: 361597303
  Source-Link: googleapis/googleapis@d060a12

feat(documentai): remove the translation fields in document.proto.
  PiperOrigin-RevId: 361590205
  Source-Link: googleapis/googleapis@0c6dd7a

fix!: remove the translation fields in document.proto. These fields are never used and will be published after a revision.
  PiperOrigin-RevId: 361589593
  Source-Link: googleapis/googleapis@63a8c9c

docs: correct label format for monitored_resource and log_entry labels for managed monitored_resource should not have forward slash labels for log_entry should not have forward slash
  Committer: @shunxian
  PiperOrigin-RevId: 361581745
  Source-Link: googleapis/googleapis@8e71120

feat: add PHP µ-generator build targets to googleads
  Committer: @aohren
  PiperOrigin-RevId: 361555541
  Source-Link: googleapis/googleapis@65d71a6

chore: update gax-java dependency to 1.62
  PiperOrigin-RevId: 361377784
  Source-Link: googleapis/googleapis@0e91521

fix(retry): restore grpc_service_config for CreateBackup and {Restore,Snapshot}Table
  Committer: @miraleung
  PiperOrigin-RevId: 361301101
  Source-Link: googleapis/googleapis@458338f

build: update gapic-generator-typescript to v1.2.10.
  This update unblocks generating IAM v1 and several more libraries that were previously blocked by their package names.
  Committer: @alexander-fenster
  PiperOrigin-RevId: 361273630
  Source-Link: googleapis/googleapis@5477122

fix: Update to PHP micro-generator beta04; fixes file layout and resource-name generation.
  PiperOrigin-RevId: 361221751
  Source-Link: googleapis/googleapis@e089d6b

fix!: remove MixedAudio BREAKING CHANGE: mixed_audio is removed from ResponseMessage
  Committer: @sheimi
  PiperOrigin-RevId: 361217394
  Source-Link: googleapis/googleapis@3b0afe5

fix!: rename the 'page_size', 'page_token', 'total_size' fields to 'limit', 'offset' and 'row_count' respectively
  PiperOrigin-RevId: 361182102
  Source-Link: googleapis/googleapis@d4cd8d9

feat: Added client libraries for Drive Activity v2 API
  PiperOrigin-RevId: 361172379
  Source-Link: googleapis/googleapis@46ab6d8

feat(metastore): Publish Dataproc Metastore v1alpha API
  PiperOrigin-RevId: 361084441
  Source-Link: googleapis/googleapis@8f11730

chore: set python target name to google-analytics-data-v1beta-py for consistency with v1alpha
  PiperOrigin-RevId: 361024282
  Source-Link: googleapis/googleapis@83f48fa

feat: Add CCAI API
  PiperOrigin-RevId: 361003369
  Source-Link: googleapis/googleapis@369e98e

feat(dialogflow): Add CCAI API
  PiperOrigin-RevId: 361000862
  Source-Link: googleapis/googleapis@4b4e8be

feat(pubsublite): add skip_backlog field to allow subscriptions to be created at HEAD
  Committer: @hannahrogers-google
  PiperOrigin-RevId: 360987981
  Source-Link: googleapis/googleapis@ead1721

chore(release): update Java microgenerator to 1.0.1
  Committer: @miraleung
  PiperOrigin-RevId: 360805639
  Source-Link: googleapis/googleapis@3befd26

feat(spanner): add `optimizer_statistics_package` field in `QueryOptions`
  PiperOrigin-RevId: 360758638
  Source-Link: googleapis/googleapis@dff6e46

docs(pubsub): Remove experimental note for schema APIs
  PiperOrigin-RevId: 360714464
  Source-Link: googleapis/googleapis@479acf6

fix: Updates copyright line.
  Committer: @itaitz
  PiperOrigin-RevId: 360703932
  Source-Link: googleapis/googleapis@c7ae03b

fix(apigateway): Provide resource definitions for service management and IAM resources
  PiperOrigin-RevId: 360690141
  Source-Link: googleapis/googleapis@d99e991

build: update package name to already published name
  PiperOrigin-RevId: 360469636
  Source-Link: googleapis/googleapis@c5435cb
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants