fix: adds assembly descriptor to snippets samples #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a jar with dependencies for the snippets samples. This is how we executed the samples in the other repository, so we are mimicking the process here.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=========================================
Coverage 84.05% 84.05%
Complexity 2503 2503
=========================================
Files 141 141
Lines 13806 13806
Branches 1317 1317
=========================================
Hits 11604 11604
Misses 1656 1656
Partials 546 546 Continue to review full report at Codecov.
|
product-auto-label
bot
added
api: spanner
olavloite
approved these changes
Oct 28, 2020
| <spanner.test.instance>default-instance</spanner.test.instance> | ||
| <spanner.sample.database>mysample</spanner.sample.database> | ||
| <spanner.quickstart.database>quickstart-db | ||
| </spanner.quickstart.database> |
There was a problem hiding this comment.
nit: could this be one line
There was a problem hiding this comment.
Oh this was broken, because of the 80 characters per column checkstyle rule.
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.3](https://www.github.com/googleapis/java-spanner-jdbc/compare/v2.3.2...v2.3.3) (2021-08-19) ### Dependencies * update dependency com.google.cloud:google-cloud-spanner-bom to v6.11.1 ([googleapis#556](https://www.github.com/googleapis/java-spanner-jdbc/issues/556)) ([36f0d32](https://www.github.com/googleapis/java-spanner-jdbc/commit/36f0d32aec65f098f7091d44a0e4acc98104aeb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a jar with dependencies for the snippets samples. This is how we executed the samples in the other repository, so we are mimicking the process here.