test: fixes gapic spanner test #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not closing the spanner service instance after using it, causing threads not to be terminated. Here we make sure to close such service in a try with resources block.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
============================================
- Coverage 85.21% 85.18% -0.03%
+ Complexity 2624 2621 -3
============================================
Files 145 145
Lines 14287 14287
Branches 1379 1379
============================================
- Hits 12174 12170 -4
- Misses 1538 1542 +4
Partials 575 575
Continue to review full report at Codecov.
|
olavloite
approved these changes
Feb 23, 2021
yoshi-automation
added a commit
that referenced
this pull request
Mar 24, 2021
Fixes #904 Source-Author: Neenu Shaji <[email protected]> Source-Date: Wed Mar 24 15:50:02 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef Source-Link: googleapis/synthtool@bb854b6
yoshi-automation
added a commit
that referenced
this pull request
Mar 30, 2021
Fixes #904 Source-Author: Neenu Shaji <[email protected]> Source-Date: Wed Mar 24 15:50:02 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef Source-Link: googleapis/synthtool@bb854b6
thiagotnunes
pushed a commit
that referenced
this pull request
Mar 30, 2021
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore(java): detect sample-secrets in build.sh
Fixes #904
Source-Author: Neenu Shaji <[email protected]>
Source-Date: Wed Mar 24 15:50:02 2021 -0400
Source-Repo: googleapis/synthtool
Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef
Source-Link: googleapis/synthtool@bb854b6
* chore: remove staging bucket v2
not needed since we removed v2 solution - googleapis/synthtool#964
Source-Author: Emily Ball <[email protected]>
Source-Date: Mon Mar 29 14:47:37 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 572ef8f70edd9041f5bcfa71511aed6aecfc2098
Source-Link: googleapis/synthtool@572ef8f
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore(java): detect sample-secrets in build.sh
Fixes googleapis#904
Source-Author: Neenu Shaji <[email protected]>
Source-Date: Wed Mar 24 15:50:02 2021 -0400
Source-Repo: googleapis/synthtool
Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef
Source-Link: googleapis/synthtool@bb854b6
* chore: remove staging bucket v2
not needed since we removed v2 solution - googleapis/synthtool#964
Source-Author: Emily Ball <[email protected]>
Source-Date: Mon Mar 29 14:47:37 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 572ef8f70edd9041f5bcfa71511aed6aecfc2098
Source-Link: googleapis/synthtool@572ef8f
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not closing the spanner service instance after using it, causing threads not to be terminated. Here we make sure to close such service in a try with resources block.
Fixes #889