Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Simplify OpenSSL checks in crypt.py. #182

Merged
merged 1 commit into from
May 18, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions oauth2client/crypt.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ class AppIdentityError(Exception):


try:
_, _package_dir, _ = imp.find_module('OpenSSL')
if not os.path.isfile(os.path.join(_package_dir, 'crypto.py')):
raise ImportError('No module named OpenSSL')
_ = imp.find_module('OpenSSL')

class OpenSSLVerifier(object):
"""Verifies the signature on a message."""
Expand Down
10 changes: 6 additions & 4 deletions tests/test_crypt.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,17 @@ def test_succeeds(self):
self.assertTrue(pem_contents in [pkcs12_key_as_pem, alternate_pem])

def test_without_openssl(self):
import os
path_isfile = os.path.isfile
import imp
imp_find_module = imp.find_module
def find_module(module_name):
raise ImportError('No module named %s' % module_name)
try:
os.path.isfile = lambda value: False
imp.find_module = find_module
reload(crypt)
self.assertRaises(NotImplementedError, crypt.pkcs12_key_as_pem,
'FOO', 'BAR')
finally:
os.path.isfile = path_isfile
imp.find_module = imp_find_module
reload(crypt)

def test_with_nonsense_key(self):
Expand Down