Introduce the 'application default credentials' concept. #24
Conversation
|
So one broader question -- I had thought that part of the simplification here would involve taking out a lot of the logic around the "well-known file". Had I misunderstood, or is that going to happen in a separate change? |
| @@ -919,7 +921,8 @@ class GoogleCredentials(OAuth2Credentials): | |||
| PROJECT = 'bamboo-machine-422' # replace this with one of your projects | |||
| ZONE = 'us-central1-a' # replace this with the zone you care about | |||
|
|
|||
| service = build('compute', 'v1', credentials=GoogleCredentials.get_default()) | |||
| service = build('compute', 'v1', | |||
| credentials=GoogleCredentials.get_application_default()) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I am not sure about that. On Wed, Jul 9, 2014 at 4:23 PM, Craig Citro [email protected]
Orest Bolohan Software Engineer (650) 214 3458 |
|
|
||
| service = build("compute", "v1", credentials=GoogleCredentials.get_default()) | ||
| service = build('compute', 'v1', | ||
| credentials=GoogleCredentials.get_application_default()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
two little nits and we're good to go. |
|
Done. Thank you for your review, Craig. All the best, On Fri, Jul 11, 2014 at 9:32 AM, Craig Citro [email protected]
Orest Bolohan Software Engineer (650) 214 3458 |
|
all is well -- do you want to squash or should I just merge? |
|
Let me exercise my squashing capabilities. Thank you, On Fri, Jul 11, 2014 at 10:06 AM, Craig Citro [email protected]
Orest Bolohan Software Engineer (650) 214 3458 |
…lt credentials' concept.
|
Please take a look now, Craig. Thank you, On Fri, Jul 11, 2014 at 10:08 AM, Orest Bolohan [email protected] wrote:
Orest Bolohan Software Engineer (650) 214 3458 |
Introduce the 'application default credentials' concept.
|
just merged. from my phone. |
Replace the 'default credentials' concept with the 'application default credentials' concept.