This repository was archived by the owner on Jan 18, 2025. It is now read-only.
100% coverage for oauth2client.contrib.multistore_file #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with mock.patch.object(multistore_file.logger, 'warn') as mock_warn: | ||
| multistore._warn_on_readonly = False | ||
| multistore._lock() | ||
| self.assertFalse(mock_warn.called) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM other than nit about cleaning up the |
|
We have a context manager for making temp files: https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/gcloud/_testing.py Can't remember why we need it, something Windows related I think. But could be useful here |
theacodes
force-pushed
the
multistore-file-coverage
branch
from
f68a62d to
2f72420
Compare
|
I just re-used their top-level file which has cleanup logic in setup and teardown. I'll consider the context managers when I re-write. This makes me miss py.test, which has proper fixtures. |
|
Very tricky! |
|
Alright @waprin let's cross that finish line! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.