This repository was archived by the owner on Jan 18, 2025. It is now read-only.
Change status access from header to attribute. #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unify all the times a status is used from the response (containing header info) of an HTTP request.
@jonparrott @nathanielmanistaatgoogle I was considering adding
transport.get_status(response)
andtransport.get_header(response)
, these are essentially the only remnants ofhttplib2
outside of thetransport
module. (The only other is thathttp.request
returnsresponse, content
and thatcontent
is alwaysbytes
.)