Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Change status access from header to attribute. #616

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 11, 2016

This is to unify all the times a status is used from the response (containing header info) of an HTTP request.


@jonparrott @nathanielmanistaatgoogle I was considering adding transport.get_status(response) and transport.get_header(response), these are essentially the only remnants of httplib2 outside of the transport module. (The only other is that http.request returns response, content and that content is always bytes.)

This is to unify all the times a status is used from the
response (containing header info) of an HTTP request.
@theacodes theacodes merged commit f439dcb into googleapis:master Aug 11, 2016
@dhermes dhermes deleted the fix-status-as-header branch August 11, 2016 18:16
@dhermes
Copy link
Contributor Author

dhermes commented Aug 11, 2016

@jonparrott @nathanielmanistaatgoogle Can you weigh in on transport.get_status(response) and transport.get_header(response)?

@theacodes
Copy link
Contributor

Let's table it until we actually try using a different transport.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 11, 2016

SGTM. I'm more concerned about flagging / fencing off all the httplib2 features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants