Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Patch to keep the raw value of the OAuth2 id_token #65

Merged
merged 2 commits into from
Nov 4, 2014

Conversation

avivien
Copy link
Contributor

@avivien avivien commented Nov 3, 2014

Path to keep the raw value of the id_token in the token_reponse attribute of the OAuth2Credentials object.
This value is needed in some case, for example for the Amazon AWS Web identity federation.
See issue #64

@avivien avivien closed this Nov 3, 2014
@avivien avivien reopened this Nov 3, 2014
@skelterjohn
Copy link
Contributor

LGTM. Not sure why it wasn't done this way in the first place.

Leaving it to @craigcitro to do final merge decisions.

if 'id_token' in d:
d['id_token'] = _extract_id_token(d['id_token'])
extracted_id_token = _extract_id_token(d['id_token'])

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@avivien
Copy link
Contributor Author

avivien commented Nov 4, 2014

Done.

@craigcitro
Copy link
Contributor

i'm going to merge and then make a small tweak -- thanks @avivien !

craigcitro added a commit that referenced this pull request Nov 4, 2014
Patch to keep the raw value of the OAuth2 id_token
@craigcitro craigcitro merged commit 2c5fabd into googleapis:master Nov 4, 2014
@avivien
Copy link
Contributor Author

avivien commented Nov 4, 2014

Thank you @craigcitro Craig.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants