Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Exclude test in find_packages #720

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Conversation

strigazi
Copy link
Contributor

To avoid conflicts with projects that have tests in their top-level
directory:

  • exlude tests in find_packages
  • add include in MANIFEST.in

Closes: #688

Signed-off-by: Spyros Trigazis [email protected]

Note: oauth2client is now deprecated. As such, it is unlikely that we will
review or merge to your pull request. We recommend you use
google-auth and oauthlib.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@strigazi
Copy link
Contributor Author

I'll sign the CLA.

Please review

@strigazi
Copy link
Contributor Author

I signed it!

@strigazi
Copy link
Contributor Author

A point release would be nice after this goes in!

MANIFEST.in Outdated
@@ -1,3 +1,4 @@
include README.md

This comment was marked as spam.

This comment was marked as spam.

setup.py Outdated
@@ -61,7 +61,7 @@
author_email='[email protected]',
url='http://github.com/google/oauth2client/',
install_requires=install_requires,
packages=find_packages(),
packages=find_packages(exclude=("tests",)),

This comment was marked as spam.

This comment was marked as spam.

@strigazi
Copy link
Contributor Author

Does the googlebot take that long to be updated?

@theacodes
Copy link
Contributor

@strigazi it's pretty instant. Are you sure you signed the CLA and authored your commits with an email associated with your account?

@theacodes
Copy link
Contributor

@strigazi github is showing an unknown author for this commit.

@strigazi
Copy link
Contributor Author

I can try my gmail. I have my CERN email as a secondary email in google account.

@theacodes
Copy link
Contributor

@strigazi this issue is the email on your commits which isn't associated with your github account. If you add your cern email to your github account, it should all work. :)

To avoid conflicts with projects that have tests in their top-level
directory:

* exlude tests in find_packages
* add include in MANIFEST.in

Closes: googleapis#688

Signed-off-by: Spyros Trigazis <[email protected]>
@googlebot
Copy link

CLAs look good, thanks!

@theacodes
Copy link
Contributor

Thanks, @strigazi! I will merge when CI passes.

@strigazi
Copy link
Contributor Author

So, it works only with my gmail :(

@strigazi
Copy link
Contributor Author

@jonparrott Can you also do a point release after?

@theacodes
Copy link
Contributor

@strigazi if you'll make a release PR (example)

@theacodes
Copy link
Contributor

(Travis passed, system test failures are expected on external PRs)

@theacodes theacodes merged commit 98c0a1a into googleapis:master Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants