-
Notifications
You must be signed in to change notification settings - Fork 432
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I'll sign the CLA. Please review |
I signed it! |
A point release would be nice after this goes in! |
MANIFEST.in
Outdated
@@ -1,3 +1,4 @@ | |||
include README.md |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
setup.py
Outdated
@@ -61,7 +61,7 @@ | |||
author_email='[email protected]', | |||
url='http://github.com/google/oauth2client/', | |||
install_requires=install_requires, | |||
packages=find_packages(), | |||
packages=find_packages(exclude=("tests",)), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Does the googlebot take that long to be updated? |
@strigazi it's pretty instant. Are you sure you signed the CLA and authored your commits with an email associated with your account? |
@strigazi github is showing an unknown author for this commit. |
I can try my gmail. I have my CERN email as a secondary email in google account. |
@strigazi this issue is the email on your commits which isn't associated with your github account. If you add your cern email to your github account, it should all work. :) |
To avoid conflicts with projects that have tests in their top-level directory: * exlude tests in find_packages * add include in MANIFEST.in Closes: googleapis#688 Signed-off-by: Spyros Trigazis <[email protected]>
CLAs look good, thanks! |
Thanks, @strigazi! I will merge when CI passes. |
So, it works only with my gmail :( |
@jonparrott Can you also do a point release after? |
(Travis passed, system test failures are expected on external PRs) |
To avoid conflicts with projects that have tests in their top-level
directory:
Closes: #688
Signed-off-by: Spyros Trigazis [email protected]
Note: oauth2client is now deprecated. As such, it is unlikely that we will
review or merge to your pull request. We recommend you use
google-auth and oauthlib.