feat: add pandas.qcut #104
Conversation
product-auto-label
bot
added
the
api: bigquery
bigframes/operations/aggregations.py
Outdated
| _apply_window_if_present(column.percent_rank(), window), | ||
| ) | ||
| float_bucket = typing.cast( | ||
| ibis_types.FloatingColumn, (percent_ranks * self._quantiles) |
There was a problem hiding this comment.
There seems to be mypy failures for this and other operations:
bigframes/operations/aggregations.py:272: error: Unsupported operand types for * ("FloatingColumn" and "int") [operator]
bigframes/operations/aggregations.py:274: error: Argument "lower" to "clip" of "NumericValue" has incompatible type "int"; expected "NumericValue | None" [arg-type]
bigframes/operations/aggregations.py:274: error: Unsupported operand types for - ("NumericValue" and "int") [operator]
bigframes/operations/aggregations.py:281: error: Unsupported operand types for < ("FloatingColumn" and "float") [operator]
bigframes/operations/aggregations.py:284: error: Unsupported operand types for <= ("FloatingColumn" and "float") [operator]
TrevorBergeron
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕