-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add pandas.qcut #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a618415
feat: add pandas.qcut
TrevorBergeron 55309f9
Merge branch 'main' into quantile
tswast 0025144
Merge branch 'main' into quantile
TrevorBergeron 5fd9448
fix mypy
TrevorBergeron 5fc040d
Merge branch 'main' into quantile
TrevorBergeron ff2b2ad
Merge branch 'main' into quantile
TrevorBergeron ad6fb4c
Merge branch 'main' into quantile
TrevorBergeron 6ee16fa
Merge branch 'main' into quantile
TrevorBergeron 073450d
Merge branch 'main' into quantile
TrevorBergeron fa12dcd
Merge branch 'main' into quantile
TrevorBergeron 5c012c2
Merge branch 'main' into quantile
TrevorBergeron dceadd0
Merge branch 'main' into quantile
gcf-merge-on-green[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat: add pandas.qcut
- Loading branch information
commit a618415d6e9536edb185a539b37a85b8735f2fca
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be mypy failures for this and other operations:
bigframes/operations/aggregations.py:272: error: Unsupported operand types for * ("FloatingColumn" and "int") [operator]
bigframes/operations/aggregations.py:274: error: Argument "lower" to "clip" of "NumericValue" has incompatible type "int"; expected "NumericValue | None" [arg-type]
bigframes/operations/aggregations.py:274: error: Unsupported operand types for - ("NumericValue" and "int") [operator]
bigframes/operations/aggregations.py:281: error: Unsupported operand types for < ("FloatingColumn" and "float") [operator]
bigframes/operations/aggregations.py:284: error: Unsupported operand types for <= ("FloatingColumn" and "float") [operator]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed