-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add Gemini-pro-1.5 to GeminiTextGenerator Tuning and Support score() method in Gemini-pro-1.5 #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Gemini-pro-1.5 to GeminiTextGenerator Tuning and Support score() method in Gemini-pro-1.5 #1208
Changes from 1 commit
97d9259
c9318d0
4f9370c
8d5e0ed
e5413a1
7b65227
9d6376b
f315f54
e9f28f4
5d2a807
dc765ec
7a40315
8be16d3
8a39a02
361a734
b213753
9de2c0e
ed001b8
9928f10
ba80d10
241ae73
205e173
6a44e7b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
…ethod in Gemini-pro-1.5 \n Bug: b/381936588 and b/344891364
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -413,6 +413,7 @@ def test_llm_palm_score_params(llm_fine_tune_df_default_index): | |
) | ||
|
||
|
||
# test score() function for "gemini-pro" and "gemini-1.5" model | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: test name already indicates it. The comment seems redundant. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
@pytest.mark.parametrize( | ||
"model_name", | ||
( | ||
|
@@ -421,7 +422,7 @@ def test_llm_palm_score_params(llm_fine_tune_df_default_index): | |
"gemini-1.5-flash-002", | ||
), | ||
) | ||
def test_llm_gemini_pro_score(model_name, llm_fine_tune_df_default_index): | ||
def test_llm_gemini_score(llm_fine_tune_df_default_index, model_name): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add for next test "test_llm_gemini_pro_score_params" as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
model = llm.GeminiTextGenerator(model_name=model_name) | ||
|
||
# Check score to ensure the model was fitted | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the consts to the top of the file for better organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done