Skip to content

refactor: make to_pandas() call to_arrow() and use local dtypes in DataFrame construction #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 26, 2023

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 23, 2023

Towards internal issue 280662868
🦕

@tswast tswast requested review from a team as code owners October 23, 2023 17:07
@tswast tswast requested a review from TrevorBergeron October 23, 2023 17:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 23, 2023
@tswast
Copy link
Collaborator Author

tswast commented Oct 24, 2023

Looks like some real test failures. Investigating.

=========================== short test summary info ============================
FAILED tests/system/small/test_dataframe.py::test_iloc_slice[0-0-None] - Asse...
FAILED tests/system/small/test_dataframe.py::test_dataframe_pct_change[2] - A...
FAILED tests/system/small/test_dataframe.py::test_iloc_slice[5-4-None] - Asse...
FAILED tests/system/small/test_numpy.py::test_df_ufuncs[log] - AssertionError...
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[sin] - AssertionE...
FAILED tests/system/small/test_numpy.py::test_df_ufuncs[log10] - AssertionErr...
FAILED tests/system/small/test_numpy.py::test_df_ufuncs[sqrt] - AssertionErro...
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[cos] - AssertionE...
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[tan] - AssertionE...
FAILED tests/system/small/test_numpy.py::test_series_binary_ufuncs[add] - Ass...
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[arcsin] - Asserti...
FAILED tests/system/small/test_numpy.py::test_series_binary_ufuncs[subtract]
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[arccos] - Asserti...
FAILED tests/system/small/test_numpy.py::test_series_binary_ufuncs[multiply]
FAILED tests/system/small/test_numpy.py::test_series_binary_ufuncs[divide] - ...
FAILED tests/system/small/test_series.py::test_mods[mod-float64_col-float64_col]
FAILED tests/system/small/test_numpy.py::test_series_binary_ufuncs[power] - A...
FAILED tests/system/small/test_series.py::test_divmods_series[divmod-float64_col-float64_col]
FAILED tests/system/small/test_series.py::test_mods[rmod-int64_col-float64_col]
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[arccosh] - Assert...
FAILED tests/system/small/test_series.py::test_mods[rmod-int64_too-float64_col]
FAILED tests/system/small/test_series.py::test_divmods_series[rdivmod-int64_col-float64_col]
FAILED tests/system/small/test_numpy.py::test_df_binary_ufuncs[power] - Asser...
FAILED tests/system/small/test_series.py::test_mods[rmod-float64_col-int64_col]
FAILED tests/system/small/test_series.py::test_mods[mod-int64_col-float64_col]
FAILED tests/system/small/test_series.py::test_mods[rmod-float64_col-int64_too]
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[arctanh] - Assert...
FAILED tests/system/small/test_series.py::test_divmods_series[rdivmod-float64_col-int64_col]
FAILED tests/system/small/test_series.py::test_mods[rmod-float64_col-float64_col]
FAILED tests/system/small/test_series.py::test_divmods_series[rdivmod-float64_col-float64_col]
FAILED tests/system/small/test_series.py::test_mods[mod-int64_too-float64_col]
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[log] - AssertionE...
FAILED tests/system/small/test_series.py::test_mods[mod-float64_col-int64_col]
FAILED tests/system/small/test_series.py::test_mods[mod-float64_col-int64_too]
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[log10] - Assertio...
FAILED tests/system/small/test_series.py::test_divmods_series[divmod-int64_col-float64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[divmod--1000-float64_col]
FAILED tests/system/small/test_numpy.py::test_series_ufuncs[sqrt] - Assertion...
FAILED tests/system/small/test_series.py::test_series_iloc[5-4-None] - Assert...
FAILED tests/system/small/test_series.py::test_divmods_series[divmod-float64_col-int64_col]
FAILED tests/system/small/test_series.py::test_string_astype_float - Assertio...
FAILED tests/system/small/test_series.py::test_divmods_scalars[divmod-678-float64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[rdivmod--1000-float64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[rdivmod-678-float64_col]
44 failed, 1374 passed, 87 skipped, 5 xfailed, 7744 warnings in 4655.38s (1:17:35)

Edit: Fixed in c2f9d72 and 7ccb61d on latest python + pandas + pyarrow, but still failing on Python 3.9 with our minimum versions.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 25, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit bfd49a5 into main Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the b280662868-to_arrow branch October 26, 2023 16:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
ashleyxuu pushed a commit that referenced this pull request Oct 26, 2023
…n DataFrame construction (#132)

Towards internal issue 280662868
🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants