Skip to content

chore: enable order_by and limit for new compiler #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

chelsea-lin
Copy link
Contributor

Fixes internal issue 419611308 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 12, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_sqlglot_order_by branch 2 times, most recently from 879cd8b to 7f5fa0c Compare June 12, 2025 21:07
@chelsea-lin chelsea-lin marked this pull request as ready for review June 12, 2025 21:48
@chelsea-lin chelsea-lin requested review from a team as code owners June 12, 2025 21:48
@chelsea-lin chelsea-lin requested a review from tswast June 12, 2025 21:48
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_sqlglot_order_by branch from 7f5fa0c to b73f03a Compare June 13, 2025 18:44
@tswast
Copy link
Collaborator

tswast commented Jun 16, 2025

Presubmit failure:

FAILED tests/system/small/ml/test_llm.py::test_gemini_preview_model_warnings[gemini-2.0-flash-exp]
= 1 failed, 2741 passed, 335 skipped, 43 xfailed, 2 xpassed, 656 warnings in 564.17s (0:09:24) =

Seems unlikely to be related to this PR.

tswast
tswast previously approved these changes Jun 16, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_sqlglot_order_by branch from a089eff to 8f27012 Compare June 16, 2025 20:29
@chelsea-lin chelsea-lin merged commit 3abc02e into main Jun 16, 2025
17 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_sqlglot_order_by branch June 16, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants