Skip to content

feat: temporary resources no longer use BigQuery Sessions #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 14, 2023
Merged

feat: temporary resources no longer use BigQuery Sessions #194

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1db08f8
feat: temporary resources no longer use BigQuery Sessions
tswast Nov 10, 2023
e96d2a3
Merge branch 'main' into b303953103-remove-session-from-session
tswast Nov 10, 2023
ecaebc6
Merge branch 'main' into b303953103-remove-session-from-session
tswast Nov 13, 2023
0b0e912
use anonymous dataset for models
tswast Nov 13, 2023
543ee7d
Merge remote-tracking branch 'origin/main' into b303953103-remove-ses…
tswast Nov 13, 2023
6cc6692
remove reference to bq session
tswast Nov 13, 2023
9ac00a2
avoid 'model already exists' error
tswast Nov 14, 2023
83d444d
remove global _model_id
tswast Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove reference to bq session
  • Loading branch information
@tswast
tswast committed Nov 13, 2023
commit 6cc66920c1c5764929d19c4b4c17b7ce029bfb7a
4 changes: 2 additions & 2 deletions bigframes/session/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def __init__(
application_name=context.application_name,
)

self._create_and_bind_bq_session()
self._create_bq_datasets()
self.ibis_client = typing.cast(
ibis_bigquery.Backend,
ibis.bigquery.connect(
Expand Down Expand Up @@ -212,7 +212,7 @@ def __hash__(self):
# Stable hash needed to use in expression tree
return hash(str(self._anonymous_dataset))

def _create_and_bind_bq_session(self):
def _create_bq_datasets(self):
"""Create and identify dataset(s) for temporary BQ resources."""
query_job = self.bqclient.query("SELECT 1", location=self._location)
query_job.result() # blocks until finished
Expand Down