Skip to content

style: Constrain footer to table width #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

style: Constrain footer to table width #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bigframes/display/table_widget.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
* limitations under the License.
*/

.bigframes-widget {
display: inline-block;
}

.bigframes-widget .table-container {
max-height: 620px;
overflow: auto;
Expand Down
9 changes: 3 additions & 6 deletions bigframes/display/table_widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ const Event = {
*/
function render({ model, el }) {
// Main container with a unique class for CSS scoping
const container = document.createElement("div");
container.classList.add("bigframes-widget");
el.classList.add("bigframes-widget");

// Structure
const tableContainer = document.createElement("div");
Expand Down Expand Up @@ -149,10 +148,8 @@ function render({ model, el }) {
footer.appendChild(paginationContainer);
footer.appendChild(pageSizeContainer);

container.appendChild(tableContainer);
container.appendChild(footer);

el.appendChild(container);
el.appendChild(tableContainer);
el.appendChild(footer);

// Initial render
handleTableHTMLChange();
Expand Down