refactor: reorganize the sqlglot scalar compiler layout - part 1 #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_refactor
branch
from
fb5dfbe to
01da466
Compare
sycai
reviewed
Sep 11, 2025
There was a problem hiding this comment.
Maybe we can still have some tests for ScalarOpCompiler's multiple register_x methods?
product-auto-label
bot
added
size: xl
sycai
previously approved these changes
Sep 15, 2025
chelsea-lin
force-pushed
the
main_chelsealin_refactor
branch
from
0bb336d to
edd54c9
Compare
sycai
approved these changes
Sep 15, 2025
chelsea-lin
added a commit
that referenced
this pull request
Sep 17, 2025
This change follows up on #2075 by splitting unary_compiler.py and its unit test file into smaller files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies same layouts from #1822 to the sqlglot scalar compiler.