Skip to content

feat: Add dataframe.to_html #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 28, 2023
Merged

feat: Add dataframe.to_html #259

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
964568c
feat: Add dataframe.to_html
Genesis929 Dec 5, 2023
1eb3fb1
temp
Genesis929 Dec 7, 2023
51160d2
lint fix
Genesis929 Dec 12, 2023
795e4d4
Merge branch 'main' into huanc-to_html-b296945119
Genesis929 Dec 12, 2023
5bbbd9f
Merge branch 'main' into huanc-to_html-b296945119
Genesis929 Dec 12, 2023
69d6247
Merge branch 'main' into huanc-to_html-b296945119
Genesis929 Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fix
  • Loading branch information
@Genesis929
Genesis929 committed Dec 12, 2023
commit 51160d235fcaa89e7e63f29f292cff2f62bc8ee5
4 changes: 2 additions & 2 deletions bigframes/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2680,7 +2680,7 @@ def to_html(
) -> str:
return self.to_pandas().to_html(
buf,
columns, # type: ignore
columns, # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to cast explicitly instead of just ignore. Better readability.

col_space,
header,
index,
Expand All @@ -2689,7 +2689,7 @@ def to_html(
float_format,
sparsify,
index_names,
justify, # type: ignore
justify, # type: ignore
max_rows,
max_cols,
show_dimensions,
Expand Down