Skip to content

chore: add the toc template file for entry page #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #325083413 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners February 13, 2024 19:25
@ashleyxuu ashleyxuu requested a review from junyazhang February 13, 2024 19:25
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 13, 2024
@ashleyxuu ashleyxuu requested a review from dandhlee February 13, 2024 19:25
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 13, 2024
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor edit.

gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 29, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes b/263399076 🦕

Updates the link to the client library reference docs page. The page doesn't exist yet but will be added in a future CL, and mentioned in the TOC from #378.
@ashleyxuu ashleyxuu force-pushed the ashleyxu-docs-template branch from b650973 to d3b6731 Compare March 4, 2024 18:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 4, 2024
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 67c2bc9 into main Mar 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-docs-template branch March 4, 2024 19:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants