-
Notifications
You must be signed in to change notification settings - Fork 48
chore: exclude pandas 2.2.x from testing #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
noxfile.py
Outdated
@@ -551,7 +551,7 @@ def prerelease(session: nox.sessions.Session, tests_path): | |||
# https://github.com/googleapis/python-bigquery-dataframes/issues/341 | |||
# https://github.com/googleapis/python-bigquery-dataframes/issues/337 | |||
# are resolved | |||
"pandas!=2.1.4, !=2.2.0rc0, !=2.2.0", | |||
"pandas<2.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI we have been following !=
approach to track the exact breaking changes with each release via the associated follow up items (in the comments above) based on the following feedback.
…nto b322845272-pandas-2.2-exclude
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have narrowed down a new breaking issue in 2.2.1, worth adding in the comments like other excluded versions
I don't think it's anything new compared to 2.2.0 as far as I can tell. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards internal issue 322845272 🦕