Skip to content

fix: change return type of Series.loc[scalar] #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 4, 2023
Merged

fix: change return type of Series.loc[scalar] #40

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
96c582e
bug: change return type of `Series.loc[scalar]`
Sep 19, 2023
4284d8f
add scalar case and update return types
Sep 21, 2023
f0e178f
remove unneeded iloc in series getitem test
Sep 22, 2023
3a48f5e
fix test_series_get_with_default_index
Sep 22, 2023
e318e1c
Run query manual for clarity/redundance
Sep 25, 2023
04477b8
Merge branch 'main' into b301166021-series-loc
milkshakeiii Sep 25, 2023
a650363
Merge branch 'main' into b301166021-series-loc
milkshakeiii Sep 25, 2023
ddd51b5
Merge branch 'main' into b301166021-series-loc
milkshakeiii Oct 3, 2023
2a9274b
Merge branch 'main' into b301166021-series-loc
milkshakeiii Oct 3, 2023
ec01a2b
Merge branch 'main' into b301166021-series-loc
milkshakeiii Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unneeded iloc in series getitem test
  • Loading branch information
Henry J Solberg committed Sep 22, 2023
commit f0e178f386b2a156396afcdf88a5b0406210ca90
2 changes: 1 addition & 1 deletion tests/system/small/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def test_series___getitem___with_default_index(scalars_dfs):
scalars_df, scalars_pandas_df = scalars_dfs
bf_result = scalars_df[col_name][key]
pd_result = scalars_pandas_df[col_name][key]
assert bf_result.to_pandas().iloc[0] == pd_result
assert bf_result == pd_result


@pytest.mark.parametrize(
Expand Down