Skip to content

feat: add ml.preprocessing.MaxAbsScaler #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2023
Merged

feat: add ml.preprocessing.MaxAbsScaler #56

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3305e5
feat: add ml.preprocessing.MaxAbsScaler
GarrettWu Sep 22, 2023
34bdbac
fix tests
GarrettWu Sep 23, 2023
7723574
fix docs
GarrettWu Sep 25, 2023
7edc856
fix mypy
GarrettWu Sep 25, 2023
0e65d10
retrigger checks
GarrettWu Sep 25, 2023
818a539
Merge branch 'main' into garrettwu-ml-preprocessing
GarrettWu Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix mypy
  • Loading branch information
@GarrettWu
GarrettWu committed Sep 25, 2023
commit 7edc85661359dc64d6f9a2b664430e736ef8b4a7
3 changes: 2 additions & 1 deletion bigframes/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import logging
import time
from typing import Optional
from typing import cast, Optional

import google.api_core.exceptions
from google.cloud import bigquery_connection_v1, resourcemanager_v3
Expand Down Expand Up @@ -80,6 +80,7 @@ def create_bq_connection(
logger.info(
f"Created BQ connection {connection_name} with service account id: {service_account_id}"
)
service_account_id = cast(str, service_account_id)
# Ensure IAM role on the BQ connection
# https://cloud.google.com/bigquery/docs/reference/standard-sql/remote-functions#grant_permission_on_function
self._ensure_iam_binding(project_id, service_account_id, iam_role)
Expand Down