Skip to content

fix: Improve escaping of literals and identifiers #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 15, 2024
Merged

fix: Improve escaping of literals and identifiers #682

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cbebeaf
fix: Improve escaping of literals and identifiers
TrevorBergeron May 10, 2024
c16294c
fix type annotations with future
TrevorBergeron May 10, 2024
79bf362
fix select generation
TrevorBergeron May 11, 2024
3bfed54
fix to_query
TrevorBergeron May 11, 2024
9057d91
restore separate quoting of each table ref component
TrevorBergeron May 13, 2024
55b72d0
fix apply axis 1 value lists
TrevorBergeron May 13, 2024
1ec2710
switch to single quoting, remove prints
TrevorBergeron May 13, 2024
0ea828f
Merge remote-tracking branch 'github/main' into sql_ids
TrevorBergeron May 13, 2024
f06d3ff
fix unit test quoting
TrevorBergeron May 13, 2024
bdf07f5
Merge remote-tracking branch 'github/main' into sql_ids
TrevorBergeron May 15, 2024
50da1d3
remove unnecessary test
TrevorBergeron May 15, 2024
9dc937e
revert unintended changes
TrevorBergeron May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restore separate quoting of each table ref component
  • Loading branch information
@TrevorBergeron
TrevorBergeron committed May 13, 2024
commit 9057d91cd98d1ba4ba3eb0d731eee7eae70a2c27
2 changes: 1 addition & 1 deletion bigframes/core/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def csv(values: Iterable[str], quoted=False) -> str:


def table_reference(table_ref: bigquery.TableReference) -> str:
return f"`{table_ref.project}.{table_ref.dataset_id}.{table_ref.table_id}`"
return f"`{escape_special_characters(table_ref.project)}`.`{escape_special_characters(table_ref.dataset_id)}`.`{escape_special_characters(table_ref.table_id)}`"


def infix_op(opname: str, left_arg: str, right_arg: str):
Expand Down