Skip to content

fix: avoid 403 response too large to return error with read_gbq and large query results #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 3, 2023
Merged

fix: avoid 403 response too large to return error with read_gbq and large query results #77

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
24b2eea
fix: avoid `403 response too large to return` error with `read_gbq` a…
tswast Oct 2, 2023
fb0a476
support struct / array in read_gbq queries
tswast Oct 3, 2023
26d8177
add unit tests for bq_schema_to_sql
tswast Oct 3, 2023
4e82017
Merge branch 'main' into b303057336-403-too-large
tswast Oct 3, 2023
43b65fe
fix mypy issue
tswast Oct 3, 2023
a538ae6
remove redundant code
tswast Oct 3, 2023
a01f03d
use fully qualified table ID
tswast Oct 3, 2023
e7f9c61
delete more dead code
tswast Oct 3, 2023
275b8cd
remove mutation from system test
tswast Oct 3, 2023
9cd372a
Merge branch 'main' into b303057336-403-too-large
tswast Oct 3, 2023
92ccd28
fix cached
tswast Oct 3, 2023
7b9487a
make BQ_STANDARD_TYPES immutable
tswast Oct 3, 2023
575fa14
ignore order in tests/system/small/ml/test_core.py::test_pca_model_pr…
tswast Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use fully qualified table ID
  • Loading branch information
@tswast
tswast committed Oct 3, 2023
commit a01f03d73563cd89dc671145737054749b6be578
4 changes: 3 additions & 1 deletion bigframes/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,7 +1300,9 @@ def _create_sequential_ordering(
cluster_cols=list(index_cols) + [default_ordering_name],
api_name=api_name,
)
table = self.ibis_client.sql(f"SELECT * FROM `{table_ref.table_id}`")
table = self.ibis_client.table(
f"{table_ref.project}.{table_ref.dataset_id}.{table_ref.table_id}"
)
ordering_reference = core.OrderingColumnReference(default_ordering_name)
ordering = core.ExpressionOrdering(
ordering_value_columns=[ordering_reference],
Expand Down