refactor: simplify ArrayValue public interface #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
TrevorBergeron
force-pushed
the
arrayvaluefactor
branch
2 times, most recently
from
55a7e52 to
454ff45
Compare
TrevorBergeron
force-pushed
the
arrayvaluefactor
branch
from
454ff45 to
8b7b26b
Compare
tswast
requested changes
Oct 5, 2023
bigframes/core/__init__.py
Outdated
| table = self._to_ibis_expr( | ||
| ordering_mode="order_by", expose_hidden_cols=True, fraction=fraction | ||
| ) | ||
| table = self._to_ibis_expr(expose_hidden_cols=True, fraction=fraction) |
There was a problem hiding this comment.
Do we know why we were using order_by mode before?
There was a problem hiding this comment.
I think it was added mistakenly. "ORDER BY" clauses shouldn't be added at this level.
bigframes/core/__init__.py
Outdated
| @@ -624,7 +606,7 @@ def corr_aggregate( | |||
| Arguments: | |||
| corr_aggregations: left_column_id, right_column_id, output_column_id tuples | |||
| """ | |||
| table = self._to_ibis_expr(ordering_mode="unordered") | |||
| table = self._to_ibis_expr() | |||
There was a problem hiding this comment.
Nit: I worry about default ordering_mode. Since behavior varies so much across modes, I don't know that there's really an intuitive default. I'd prefer we be explicit.
bigframes/core/__init__.py
Outdated
| if sorted: | ||
| sql = textwrap.dedent( | ||
| f""" | ||
| SELECT * EXCEPT ({offsets_id}) |
There was a problem hiding this comment.
Let's wrap this in backticks in case we use spaces or some other characters in the column name.
bigframes/core/__init__.py
Outdated
| table = self._to_ibis_expr(expose_hidden_cols=expose_extra_columns) | ||
| sql = self._session.ibis_client.compile(table) # type:ignore | ||
|
|
||
| # DO NOT COMMIT: Make this ordered |
tswast
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕