refactor: all ArrayValue ops return only ArrayValue #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
tswast
reviewed
Oct 12, 2023
| def __call__( | ||
| self, left_column_ids: Sequence[str], right_column_ids: Sequence[str] | ||
| ) -> Tuple[Mapping[str, str], Mapping[str, str]]: | ||
| """When joining column ids from different namespaces, this function defines how names are remapped. Map only non-hidden ids.""" |
There was a problem hiding this comment.
I see here you warn to "Map only non-hidden IDs" but we are passing in some hidden columns in bigframes/core/joins/row_identity.py
There was a problem hiding this comment.
Adjusted code comment to reflect the real constraint: hidden ids should be mapped in a separate namespace as they are compile context-dependent, while value columns names must be fixed regardless of compilation modes.
tswast
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕