Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

fix: add dataset id in function call #44

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #43

@HemangChothani HemangChothani requested review from shollyman and a team as code owners September 11, 2020 09:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2020
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a test that failed because of that? If not, I suggest adding one that covers this code path to protect us from future regressions.

The fix itself looks good.

@HemangChothani
Copy link
Contributor Author

@plamut We are using test_create_scheduled_query.py file for testing, but this is call is from main function and use argument parser like for quickstart.py test

if __name__ == '__main__':
run_quickstart()

not sure how to cover this kind of call and also not found for the quickstart as well.

@plamut
Copy link
Contributor

plamut commented Sep 11, 2020

@HemangChothani OK, fair enough, let's merge it then. 👍

@plamut plamut merged commit 9ce59a4 into googleapis:master Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample of create_scheduled_query.py is not working
2 participants