This repository was archived by the owner on Nov 29, 2023. It is now read-only.
chore: change default retry policies timeouts (via synth) #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This was referenced Sep 15, 2020
|
Hmm, a few docstrings seem to have bad indentation, causing the docs to complain... will fix it. |
product-auto-label
bot
added
the
api: bigquerydatatransfer
plamut
force-pushed
the
synth-update
branch
from
52f857b to
c1978f5
Compare
1 task
1 task
tswast
approved these changes
Sep 16, 2020
| requested_time_range (Union[dict, ~google.cloud.bigquery_datatransfer_v1.types.TimeRange]): Time range for the transfer runs that should be started. | ||
|
|
||
| If a dict is provided, it must be of the same form as the protobuf | ||
| message :class:`~google.cloud.bigquery_datatransfer_v1.types.TimeRange` | ||
| requested_run_time (Union[dict, ~google.cloud.bigquery_datatransfer_v1.types.Timestamp]): Specific run_time for a transfer run to be started. The | ||
| requested_run_time must not be in the future. | ||
| requested_run_time (Union[dict, ~google.cloud.bigquery_datatransfer_v1.types.Timestamp]): Protocol Buffers - Google's data interchange format Copyright 2008 |
There was a problem hiding this comment.
Quite the docstring! Doesn't seem like the license should be part of an argument description, but I realize this is autogenned from proto source.
leahecole
requested review from
leahecole
and removed request for
leahecole
|
Not seeing anything super samples-y, and trust Bu Sun + Tim more than me on this one :) |
busunkim96
approved these changes
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the generated parts of the code up to date, replacing several synth PRs that are quite old now (#35, #36, and #37).
The goal is to clean up the currently open PRs, make one last Python 2 compatible release, and then proceed with the migration to microgenerator.