-
Notifications
You must be signed in to change notification settings - Fork 125
Test on Python37 #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Python37 #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following files do not match the black
styleguide:
- nox.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following files do not match the black
styleguide:
- nox.py
@tswast let me know if you recognize these ADC errors in the 3.7 build: https://travis-ci.org/max-sixty/pandas-gbq/jobs/422752133 Could they be related to us using sudo (which is required for 3.7 it seems)? |
This reverts commit 60e8e85.
I think this is related to the fact that Travis CI runs on GCE but it locks down access to APIs. Maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's
- Sync to master
- Make sure we include a Python 3.6 build, still.
I think syncing to master should pick up the fix for #226, which looks like the same reason that the Python 3.7 build was failing here.
Python 3.7 builds added in #232 |
What do you think about skipping conda tests for the moment @tswast ?
The test on 3.7 seems less controversial (probably should split these up, but both small PRs)