Skip to content

feat: add 'columns' as an alias for 'col_order' #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 6, 2023
Merged

feat: add 'columns' as an alias for 'col_order' #701

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7abf188
feat: add 'columns' as an alias for 'col_order'
kiraksi Nov 21, 2023
5b7b112
Added test to test alias correctness
kiraksi Nov 21, 2023
4bdc620
reformatted with black
kiraksi Nov 21, 2023
597b4c8
refactored to alias checking and testing
kiraksi Nov 27, 2023
fa83832
Reformatted tests for columns alias
kiraksi Nov 27, 2023
c26d2fe
Merge branch 'main' into add-columns-alias
chalmerlowe Nov 28, 2023
fc42a1d
feat: add 'columns' as an alias for 'col_order'
kiraksi Nov 21, 2023
5643cf4
Added test to test alias correctness
kiraksi Nov 21, 2023
e51d010
reformatted with black
kiraksi Nov 21, 2023
984c353
refactored to alias checking and testing
kiraksi Nov 27, 2023
ef66ac3
Reformatted tests for columns alias
kiraksi Nov 27, 2023
6d7f821
Made col_order a keyword argument and added to-do
kiraksi Nov 28, 2023
653e93e
Edit todo comment
kiraksi Nov 28, 2023
1b38d0c
merged main
kiraksi Nov 28, 2023
f22f95c
Fixed small error in docstring
kiraksi Nov 28, 2023
3a5368b
Fixed valueerror message
kiraksi Dec 2, 2023
6e957f7
Merge branch 'main' into add-columns-alias
kiraksi Dec 2, 2023
b71b407
reformatted with black
kiraksi Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed valueerror message
  • Loading branch information
@kiraksi
kiraksi committed Dec 2, 2023
commit 3a5368bee544fc7cfc9ce203ae9fbe9025a180f6
2 changes: 1 addition & 1 deletion pandas_gbq/gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ def read_gbq(
if col_order and not columns:
columns = col_order
elif col_order and columns:
raise ValueError("Must specify either columns or col_order, not both")
raise ValueError("Must specify either columns (preferred) or col_order, not both")

# Change the order of columns in the DataFrame based on provided list
# TODO(kiraksi): allow columns to be a subset of all columns in the table, with follow up PR
Expand Down