-
Notifications
You must be signed in to change notification settings - Fork 323
Expose jobTimeoutMs in JobConfig #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose jobTimeoutMs in JobConfig #1656
Conversation
Exposes job timeout setting in Python job timeout config. https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobConfiguration.FIELDS.job_timeout_ms
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for submitting this PR.
I suspect that we might want to put your tests in the following file: We may want to go further than just checking to see if we can set the |
google/cloud/bigquery/job/base.py
Outdated
super(_JobConfig, self).__setattr__(name, value) | ||
|
||
@property | ||
def jobtimeout(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: normally we use snake_case to transform from rest API to python.
I'd prefer job_timeout_ms
unless we change this to accept a datetime.timedelta
, in which case job_timeout
may make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW: We use default_table_expiration_ms
here:
def default_table_expiration_ms(self): |
This PR was superceded by PR 1675. |
Fixes #1421
Exposes job timeout setting in Python job timeout config.
https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobConfiguration.FIELDS.job_timeout_ms
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: