Skip to content

Conversation

nickmarx12345678
Copy link
Contributor

Move instructions off deprecated module.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Move instructions off deprecated module.
@nickmarx12345678 nickmarx12345678 requested review from a team as code owners December 4, 2023 20:27
Copy link

google-cla bot commented Dec 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 4, 2023
@Linchin
Copy link
Contributor

Linchin commented Dec 5, 2023

Hi @nickmarx12345678, thank you for contributing to this repo! Please sign the cla agreement, it's legally required to make code changes.

@nickmarx12345678
Copy link
Contributor Author

nickmarx12345678 commented Dec 5, 2023 via email

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2023
@parthea parthea changed the title Update README.rst docs: Update README.rst Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 8, 2023
@parthea parthea changed the title docs: Update README.rst docs: Update OpenTelemetry section in README.rst Dec 8, 2023
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 18, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 18, 2023
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2023
@chalmerlowe chalmerlowe self-assigned this Dec 19, 2023
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 21, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 21, 2023
@chalmerlowe chalmerlowe merged commit a65aaa6 into googleapis:main Dec 21, 2023
@nickmarx12345678 nickmarx12345678 deleted the patch-1 branch December 21, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants