Skip to content

fix: Remove duplicate key time_partitioning from Table._PROPERTY_TO_A… #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix: Remove duplicate key time_partitioning from Table._PROPERTY_TO_A… #1898

merged 5 commits into from
Apr 12, 2024

Conversation

toransahu
Copy link
Contributor

…PI_FIELD

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@toransahu toransahu requested review from a team as code owners April 12, 2024 12:09
@toransahu toransahu requested a review from farhan0102 April 12, 2024 12:09
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 12, 2024
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@chalmerlowe chalmerlowe self-assigned this Apr 12, 2024
@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2024
chalmerlowe
chalmerlowe approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 82ae908 into googleapis:main Apr 12, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2024
@release-please release-please bot mentioned this pull request Apr 12, 2024
Merged
This was referenced Apr 23, 2024
Closed
Closed
Closed
@toransahu toransahu deleted the toran branch June 6, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@farhan0102 farhan0102 Awaiting requested review from farhan0102 farhan0102 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toransahu @chalmerlowe @yoshi-kokoro