Skip to content

Conversation

chalmerlowe
Copy link
Collaborator

This PR adds a calculation_duration function to figure out how long each of the nox sessions takes to complete.

This allows us to troubleshoot issues if a session seems to be taking longer than expected.

@chalmerlowe chalmerlowe requested review from a team as code owners May 15, 2024 14:26
@chalmerlowe chalmerlowe requested a review from Linchin May 15, 2024 14:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 15, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowe chalmerlowe merged commit ea750e0 into main May 16, 2024
@chalmerlowe chalmerlowe deleted the clowe-adds-timer-decorator branch May 16, 2024 12:02
@tswast
Copy link
Contributor

tswast commented May 29, 2024

FYI: This showed up in the public release notes because of the use of feat: in the commit. chore: may have been more appropriate since users of google-cloud-bigquery shouldn't care about this change.

@chalmerlowe
Copy link
Collaborator Author

@tswast
I was unaware of the downstream effects of choosing feat: vs chore:. Thanks for this heads up.
Oops.
Will keep that in mind for the future.

CC: @Linchin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants