Skip to content

chore(x-goog-spanner-request-id): add x_goog_spanner_request_id as an attribute to OTEL spans #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

odeke-em
Copy link
Contributor

This change is effectively 3/3 of the work to complete x-goog-spanner-request-id propagation. While here instrumented batch_write as well to send over the header too.

Updates #1261

@odeke-em odeke-em requested review from a team as code owners May 21, 2025 01:31
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels May 21, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2025
odeke-em added 2 commits May 21, 2025 02:30
… attribute to OTEL spans

This change is effectively 3/3 of the work to complete
x-goog-spanner-request-id propagation. While here instrumented
batch_write as well to send over the header too.

Updates googleapis#1261
@odeke-em odeke-em force-pushed the propagate-x_goog_spanner_request_id-to-OTEL-span branch from 7da3a4f to 60346bb Compare May 21, 2025 09:32
@sakthivelmanii sakthivelmanii added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2025
@olavloite olavloite merged commit bae395d into googleapis:main May 21, 2025
18 of 19 checks passed
@odeke-em odeke-em deleted the propagate-x_goog_spanner_request_id-to-OTEL-span branch May 21, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants