Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=googleapis_gapic-generator-java&metric=coverage)](https://sonarcloud.io/summary/new_code?id=googleapis_gapic-generator-java)

This repository has been renamed to `sdk-platfom-java`.
For developers, please update the repo's URL in repository clones (this is not actually strictly required because redirection works).
For more information, please refer to [rename a repository](https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository).

This repository consists of the following modules:

- **[gapic-generator-java](./gapic-generator-java/README.md)**: the Protobuf compiler plugin to generate Java code.
Expand Down
10 changes: 5 additions & 5 deletions gapic-generator-java-pom-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<version>2.19.1-SNAPSHOT</version><!-- {x-version-update:gapic-generator-java:current} -->
<packaging>pom</packaging>
<name>GAPIC Generator Java POM Parent</name>
<url>https://github.com/googleapis/gapic-generator-java</url>
<url>https://github.com/googleapis/sdk-platform-java</url>
<description>
The top-level parent for all modules in the repository.
</description>
Expand Down Expand Up @@ -50,13 +50,13 @@
</organization>
<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false"
child.scm.url.inherit.append.path="false">
<connection>scm:git:[email protected]:googleapis/gapic-generator-java.git</connection>
<developerConnection>scm:git:[email protected]:googleapis/gapic-generator-java.git</developerConnection>
<url>https://github.com/googleapis/gapic-generator-java</url>
<connection>scm:git:[email protected]:googleapis/sdk-platform-java.git</connection>
<developerConnection>scm:git:[email protected]:googleapis/sdk-platform-java.git</developerConnection>
<url>https://github.com/googleapis/sdk-platform-java</url>
<tag>HEAD</tag>
</scm>
<issueManagement>
<url>https://github.com/googleapis/gapic-generator-java/issues</url>
<url>https://github.com/googleapis/sdk-platform-java/issues</url>
<system>GitHub Issues</system>
</issueManagement>

Expand Down
12 changes: 6 additions & 6 deletions gapic-generator-java/DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,15 @@ To generate a production GAPIC API:

http_archive(
name = "gapic_generator_java",
strip_prefix = "gapic-generator-java-%s" % _gapic_generator_java_version,
urls = ["https://github.com/googleapis/gapic-generator-java/archive/v%s.zip" % _gapic_generator_java_version],
strip_prefix = "sdk-platform-java-%s" % _gapic_generator_java_version,
urls = ["https://github.com/googleapis/sdk-platform-java/archive/v%s.zip" % _gapic_generator_java_version],
)

# gax-java is part of gapic-generator-java repository
# gax-java is part of sdk-platform-java repository
http_archive(
name = "com_google_api_gax_java",
strip_prefix = "gapic-generator-java-%s/gax-java" % _gapic_generator_java_version,
urls = ["https://github.com/googleapis/gapic-generator-java/archive/v%s.zip" % _gapic_generator_java_version],
strip_prefix = "sdk-platform-java-%s/gax-java" % _gapic_generator_java_version,
urls = ["https://github.com/googleapis/sdk-platform-java/archive/v%s.zip" % _gapic_generator_java_version],
)
```

Expand All @@ -139,7 +139,7 @@ To generate a production GAPIC API:
path = "/absolute/path/to/your/local/gapic-generator-java",
)

# gax-java is part of gapic-generator-java repository
# gax-java is part of sdk-platform-java repository
local_repository(
name = "com_google_api_gax_java",
path = "/absolute/path/to/your/local/gapic-generator-java/gax-java",
Expand Down
2 changes: 1 addition & 1 deletion gapic-generator-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@

<!--
TODO: remove when dropping Java 8.
https://github.com/googleapis/gapic-generator-java/issues/888
https://github.com/googleapis/sdk-platform-java/issues/888
-->
<dependency>
<groupId>javax.annotation</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ protected MethodDefinition createStartStaticServerMethod(
varInitExprs.add(serviceToVarInitExprFn.apply(service));
mockServiceVarExprs.add(serviceToVarExprFn.apply(service));
// Careful: Java 8 and 11 make different ordering choices if this set is not explicitly sorted.
// Context: https://github.com/googleapis/gapic-generator-java/pull/750
// Context: https://github.com/googleapis/sdk-platform-java/pull/750
for (Service mixinService :
context.mixinServices().stream()
.sorted((s1, s2) -> s2.name().compareTo(s1.name()))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void parseHttpAnnotation_missingFieldFromMessage() {
// will then serialize all sub fields to query params.
// We need to either traverse all the leaf level fields and exclude field in the generator or pass
// the excluded fields to gax-java. Re-enable this test once
// https://github.com/googleapis/gapic-generator-java/issues/1041 is fixed
// https://github.com/googleapis/sdk-platform-java/issues/1041 is fixed
public void parseHttpAnnotation_shouldExcludeFieldsFromQueryParamsIfPathParamsAreConfigured() {
FileDescriptor fileDescriptor = HttpRuleParserTestingOuterClass.getDescriptor();
ServiceDescriptor serviceDescriptor = fileDescriptor.getServices().get(0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ service HttpRuleParserTesting {
};
}

//TODO: Add more test cases once https://github.com/googleapis/gapic-generator-java/issues/1041 is fixed
//TODO: Add more test cases once https://github.com/googleapis/sdk-platform-java/issues/1041 is fixed
}

enum Continent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public interface LongRunningOrBuilder
* long-running operation pattern.
* All default values below are from those used in the client library
* generators (e.g.
* [Java](https://github.com/googleapis/gapic-generator-java/blob/04c2faa191a9b5a10b92392fe8482279c4404803/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java)).
* [Java](https://github.com/googleapis/sdk-platform-java/blob/04c2faa191a9b5a10b92392fe8482279c4404803/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java)).
* </pre>
*
* Protobuf type {@code google.api.MethodSettings.LongRunning}
Expand Down Expand Up @@ -639,7 +639,7 @@ protected Builder newBuilderForType(
* long-running operation pattern.
* All default values below are from those used in the client library
* generators (e.g.
* [Java](https://github.com/googleapis/gapic-generator-java/blob/04c2faa191a9b5a10b92392fe8482279c4404803/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java)).
* [Java](https://github.com/googleapis/sdk-platform-java/blob/04c2faa191a9b5a10b92392fe8482279c4404803/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java)).
* </pre>
*
* Protobuf type {@code google.api.MethodSettings.LongRunning}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ message MethodSettings {
// long-running operation pattern.
// All default values below are from those used in the client library
// generators (e.g.
// [Java](https://github.com/googleapis/gapic-generator-java/blob/04c2faa191a9b5a10b92392fe8482279c4404803/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java)).
// [Java](https://github.com/googleapis/sdk-platform-java/blob/04c2faa191a9b5a10b92392fe8482279c4404803/src/main/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposer.java)).
message LongRunning {
// Initial delay after which the first poll request will be made.
// Default value: 5 seconds.
Expand Down
2 changes: 1 addition & 1 deletion java-core/.repo-metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"api_shortname": "google-cloud-core",
"client_documentation": "https://github.com/googleapis/gapic-generator-java/tree/main/java-core",
"client_documentation": "https://github.com/googleapis/sdk-platform-java/tree/main/java-core",
"name_pretty": "Google Cloud Core",
"release_level": "stable",
"language": "java",
Expand Down