Skip to content

chore: add 2 minute timeout to GrpcDirectStreamControllerTest #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
burkedavison merged 2 commits into from
May 23, 2023
Merged

chore: add 2 minute timeout to GrpcDirectStreamControllerTest #1690

burkedavison merged 2 commits into from
May 23, 2023

Conversation

@burkedavison
Copy link
Member

@burkedavison burkedavison commented May 19, 2023

@burkedavison burkedavison requested a review from a team as a code owner May 19, 2023 14:23
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 19, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 19, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 19, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 19, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lqiu96
lqiu96 approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll take a deeper look at this flaky test.

@burkedavison burkedavison merged commit 96324c2 into main May 23, 2023
@burkedavison burkedavison deleted the add-timeout-GrpcDirectSTreamControllerTest branch May 23, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 left review comments

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burkedavison @blakeli0 @lqiu96