Skip to content

fix: update tag workflow #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alicejli merged 2 commits into from
May 23, 2023
Merged

fix: update tag workflow #1699

alicejli merged 2 commits into from
May 23, 2023

Conversation

@alicejli
Copy link
Contributor

@alicejli alicejli commented May 23, 2023

Replacement for #1695

This fixes a couple issues with the original workflow:

  1. Skips tags that are already created instead of failing
  2. Uses exact matches for artifact IDs (multiple artifacts that begin with gax were causing issues)
  3. Removes manual input for manual trigger; will automatically take the latest release which is what we want.

@alicejli alicejli requested a review from a team as a code owner May 23, 2023 18:25
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 23, 2023
@alicejli alicejli requested a review from suztomo May 23, 2023 18:26
suztomo
suztomo reviewed May 23, 2023
View reviewed changes
suztomo
suztomo requested changes May 23, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alicejli alicejli merged commit a988fe7 into main May 23, 2023
@alicejli alicejli deleted the updateReleaseTagWorkflow branch May 23, 2023 20:16
@release-please release-please bot mentioned this pull request May 23, 2023
Merged
@alicejli alicejli mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alicejli @suztomo