Skip to content

chore: refactor StreetViewCameraPositionState setPosition #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

GeorgCantor
Copy link
Contributor

@GeorgCantor GeorgCantor commented Nov 10, 2024

Use of when Expression: The when expression is used to handle different combinations of radius and source, making it clear and concise.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

simplify the conditional logic
@dkhawk dkhawk changed the title Update StreetViewCameraPositionState.kt chore: refactor StreetViewCameraPositionState setPosition Jan 23, 2025
@dkhawk dkhawk merged commit f48f421 into googlemaps:main Jan 23, 2025
10 of 11 checks passed
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 6.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants