fix: fixed issue on MarkerComposable #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
dkhawk
approved these changes
Apr 15, 2025
dkhawk
approved these changes
Apr 17, 2025
dkhawk
approved these changes
Apr 17, 2025
googlemaps-bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
## [6.5.3](v6.5.2...v6.5.3) (2025-04-18) ### Bug Fixes * fixed issue on MarkerComposable ([#701](#701)) ([0c51438](0c51438))
|
🎉 This PR is included in version 6.5.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that was not properly done on the MarkerComposable, and that was probably introducing some performance issues (not all the problems we had were attributable to it, but certainly a percentage of them).
The main issue is that we have been measuring the view after drawing it. The procedure should have been measure and layout, then draw.
The
fakeCanvaswas also unnecessary, sinceapplyCanvascreates one.So overall, this should improve performance a bit.