Skip to content

librerpl: port to Windows #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2021
Merged

librerpl: port to Windows #276

merged 3 commits into from
Sep 25, 2021

Conversation

@compnerd
Copy link
Contributor

@compnerd compnerd commented Sep 21, 2021

No description provided.

@compnerd
Copy link
Contributor Author

compnerd commented Sep 21, 2021

@saelo - this is a fairly large change, but Im not sure how to split it up. It adds a compile-only tested windows equivalences for the operations. I suspect that similar to libsocket, it will be preferable to split this up into two files.

@saelo
Copy link
Collaborator

saelo commented Sep 22, 2021

Awesome! Yeah I think I'd prefer splitting it up into at least libreprl-posix and libreprl-win32 again. There seem to be almost no functions that don't need ifdefs, but those that don't could, I guess, move into a libreprl-common if that makes sense? But I'm also fine with just duplicating them.

@compnerd
Copy link
Contributor Author

compnerd commented Sep 23, 2021

I'll try to update this soon, sorry for the delay here. I still have a few other patches that I am trying to drain.

@saelo
Copy link
Collaborator

saelo commented Sep 23, 2021

Sure, absolutely no worries!

@compnerd
librerpl: port to Windows
5806970 
Add an initial port to windows.  The subprocess command generation could be
improved to handle quoting properly and to enable unicode.  However, this is a
first step towards supporting Windows.
@compnerd
libreprl: split out POSIX and Win32 paths
1a9c18b 
Create a separate source file for the Windows path.
@compnerd compnerd changed the title WIP/librerpl: port to Windows librerpl: port to Windows Sep 24, 2021
saelo
saelo reviewed Sep 25, 2021
View reviewed changes
Copy link
Collaborator

@saelo saelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question, but I think then this is ready to be merged. WDYT?

@saelo saelo merged commit af6a717 into googleprojectzero:main Sep 25, 2021
@compnerd compnerd deleted the reprl-windows branch September 25, 2021 22:52
Dudcom pushed a commit to VRIG-RITSEC/fuzzillai that referenced this pull request Oct 29, 2025
@compnerd
librerpl: port to Windows (googleprojectzero#276)
fad1525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saelo saelo saelo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@compnerd @saelo