Yang #464
Merged
Yang #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caller9
reviewed
Jun 23, 2020
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MainActivity.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MainActivity.kt
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MapsFragment.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MainActivity.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/RunFragment.kt
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Jun 24, 2020
Closed
Stopwatch will keep working when users switch to other App/Interface 2. Add permission request callback. The map view will be refreshed automatically after getting the Location permission
xyarco
reviewed
Jun 26, 2020
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MainActivity.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/RunFragment.kt
Outdated
Show resolved
Hide resolved
2. Adjust the Naming style and part of useless datablocks
caller9
reviewed
Jun 29, 2020
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/StopwatchView.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MainActivity.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/RunFragment.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/RunFragment.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/RunFragment.kt
Outdated
Show resolved
Hide resolved
Still have some automatically generated unused code blocks and comments. Will delete them in the future, in case they will be used.
Closed
caller9
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three updates
basic bottom navigation view(main activity) -- Run fragment, Map fragment and profile fragment
Run fragment -- Stopwatch function. Start, pause and resume timer
Map fragment -- Requesting Device Location Permission, Get Device Location, add map marker of current location