Firestore #479
Merged
Firestore #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Profile UI 3. Data binding for user name and email 4. Async Task class to Download and set user photo 5. Create ProfileViewModel
xyarco
reviewed
Aug 13, 2020
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/LoginFragment.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/ProfileViewModel.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/SignInViewModel.kt
Outdated
Show resolved
Hide resolved
caller9
reviewed
Aug 13, 2020
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/LoginFragment.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/MainActivity.kt
Outdated
Show resolved
Hide resolved
android/canonical/app/src/main/java/com/google/samples/quickstart/canonical/ProfileViewModel.kt
Outdated
Show resolved
Hide resolved
| val runHistoryListForView : ArrayList<ProfileViewModel.SingleRun> | ||
| = profileVM.getRunHistoryListForView() | ||
| val runHistoryAdapter = RunHistoryAdapter(requireContext(), runHistoryListForView) | ||
| val runHistoryListView = view?.findViewById<ListView>(R.id.run_history_list_view) |
There was a problem hiding this comment.
RecyclerView is the modern replacement for ListView. For this case I think ListView is fine. https://developer.android.com/jetpack/androidx/releases/recyclerview?hl=en
caller9
reviewed
Aug 17, 2020
.../app/src/androidTest/java/com/google/samples/quickstart/canonical/DatabaseInteractionTest.kt
Outdated
Show resolved
Hide resolved
.../app/src/androidTest/java/com/google/samples/quickstart/canonical/DatabaseInteractionTest.kt
Show resolved
Hide resolved
...onical/app/src/androidTest/java/com/google/samples/quickstart/canonical/LoginFragmentTest.kt
Outdated
Show resolved
Hide resolved
...nonical/app/src/androidTest/java/com/google/samples/quickstart/canonical/MapsFragmentTest.kt
Outdated
Show resolved
Hide resolved
caller9
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Profile UI
2.Construction and connection of Firestore
3.Async Task class to Download and set user photo
4.Interaction between runFragment and Firestore
5.Login status Observer