feat(compactor HS): add a job runner for processing of deletion jobs #18058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
force-pushed
the
deletion-job-runner
branch
from
4afac3b to
c235cef
Compare
sandeepsukhani
force-pushed
the
deletion-job-runner
branch
from
c235cef to
a86414f
Compare
paul1r
reviewed
Jun 11, 2025
pkg/compactor/deletion/job_runner.go
Outdated
| } | ||
|
|
||
| // get the chunk from storage | ||
| chks, err := chunkClient.GetChunks(context.Background(), []chunk.Chunk{chk}) |
There was a problem hiding this comment.
use the ctx parameter here instead of context.Background?
paul1r
reviewed
Jun 11, 2025
| var filterFuncs []filter.Func | ||
|
|
||
| tableInterval := retention.ExtractIntervalFromTableName(deletionJob.TableName) | ||
| for _, chunkID := range deletionJob.ChunkIDs { |
There was a problem hiding this comment.
If we have a lot of chunks, this would be a lot of loop iterations. Should we consider using a worker pool of some sort here? Can be in a future code iteration, of course
There was a problem hiding this comment.
I was going to introduce a concurrency after some testing. I have left a comment for now to avoid missing it.
Thanks!
paul1r
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As a follow-up to work on making Compactor horizontally scalable for processing delete requests, this PR adds a job runner that executes the deletion jobs. The Deletion Job runner would download the chunks from the object storage, apply the filters from the given delete requests, upload any newly built chunks with deleted lines filtered out and build a job response which includes:
Checklist