Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Add boiler plate code for flamegraph and readme about dev setup #125

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Jul 26, 2022

This is to be used together with this proof of concept PR grafana/grafana#52057.

All of this is a Draft for now as the API probably needs some feedback.

To set this all up this needs some work which hopefully won't be needed in the future or can be streamlined.

To test

  • Checkout this and Explore: Make visualisation to data mapping more dynamic grafana#52057
  • In grafana repo packages/grafana-data/package.json, change "@grafana/schema": "9.1.0-pre", to "@grafana/schema": "9.0.4",. We will link @grafana/data later on and the 9.1.0-pre version would not be recognized from Fire repo
  • cd grafana/data/plugins
  • ln -s fire/grafana/flamegraph
  • ln -s fire/grafana/fire-datasource
  • cd fire/grafana/flamegraph
  • yarn link grafana/packages/grafana-data this will change the resolutions part in package.json TODO: check if this can be relative path or how to prevent rewriting this all the time
  • yarn install
  • yarn build
  • cd fire/grafana/fire-datasource
  • yarn install
  • yarn build
  • mage -v
  • start grafana

Now you should be able to create Fire data source and if you query it should load the flamegraph plugin (no UI yet though)

@aocenas aocenas changed the title Some dummy code to test dynamic loading of visualisations in Grafana Add boiler plate code for flamegraph and readme about dev setup Aug 2, 2022
@aocenas aocenas marked this pull request as ready for review August 2, 2022 13:29
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aocenas aocenas merged commit bfa7fed into main Aug 2, 2022
@aocenas aocenas deleted the aocenas/dummy-dynamic-panel branch August 2, 2022 14:03
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants