This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Add block opened metrics #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Jun 21, 2023
simonswine
approved these changes
Jun 21, 2023
Co-authored-by: Christian Simon <[email protected]>
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Add block opened metrics * Add fake metrics to tests to fix it * Update pkg/phlaredb/metrics.go Co-authored-by: Christian Simon <[email protected]> --------- Co-authored-by: Christian Simon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the number of block currently opened and also the total samples in memory.