-
Notifications
You must be signed in to change notification settings - Fork 660
fix: delete app also deletes metadata #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.59% // Head: 66.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
- Coverage 66.59% 66.21% -0.37%
==========================================
Files 169 169
Lines 5563 5560 -3
Branches 1260 1258 -2
==========================================
- Hits 3704 3681 -23
- Misses 1849 1869 +20
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks just great :) I left a couple of notes – nothing really important but give them a look please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add an
ApplicationService
that bridgesApplicationMetadataService
andStorage
.The operations
List
,Get
,Create
are relayed toApplicationMetadataService
only.Now
Delete
is relayed to bothApplicationMetadataService
ANDStorage
. This is so that when one is deleting an App, it must be deleted from storage but ALSO be deleted from the metadata database. Otherwise the application will still be shown in the application dropdown.Also moved handlers code to
/api
to keep things consistent with the new way we are managing these handlers.Although there are no tests there (they are still in the admin package)