Skip to content

feat(chart): ingressClassName and tls for ingress #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2023
Merged

feat(chart): ingressClassName and tls for ingress #2502

merged 8 commits into from
Oct 17, 2023

Conversation

jjangga0214
Copy link
Contributor

No description provided.

@jjangga0214 jjangga0214 requested a review from a team as a code owner October 8, 2023 16:24
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kolesnikovae
kolesnikovae reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jjangga0214! 🎉

Could you please add empty attributes to the value file and run helm/docs?

@kolesnikovae
Copy link
Collaborator

Hello @jjangga0214, could you please resolve the review comments? I think that the change might be also interesting for others, therefore I'd like to get it merged

@jjangga0214
Copy link
Contributor Author

@kolesnikovae Done :)
Thank you for the review and maintenance!

@kolesnikovae
Copy link
Collaborator

Thank you @jjangga0214! Could you also please run helm/check and push the updated templates?

simonswine
simonswine approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was useful to have that sooner, so I ran helm check and commited the result.

lgtm

Thanks for the contriubtion @jjangga0214 🙂

@simonswine simonswine merged commit 2849658 into grafana:main Oct 17, 2023
@jjangga0214 jjangga0214 deleted the patch-1 branch October 17, 2023 14:02
@simonswine simonswine mentioned this pull request Oct 17, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae left review comments

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjangga0214 @CLAassistant @kolesnikovae @simonswine