Skip to content

feat: add enabling symbolizer override #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marcsanmi
Copy link
Contributor

@marcsanmi marcsanmi commented Apr 24, 2025

This PR adds the capability to enable and disable symbolizer through internal system overrides.
The whole flow can be summarised as:

  • First, check if the symbolizer service is globally enabled (via v2 experiment flag)
  • Then, for each request, check if symbolization is enabled for the tenant(s)

@marcsanmi marcsanmi requested a review from a team as a code owner April 24, 2025 09:15
@marcsanmi marcsanmi requested a review from kolesnikovae April 24, 2025 18:46
@marcsanmi marcsanmi force-pushed the marcsanmi/add-enable-symbolizer-overrides branch from 821610f to 8103ad4 Compare April 24, 2025 18:51
@marcsanmi marcsanmi requested a review from kolesnikovae April 25, 2025 10:42
@marcsanmi marcsanmi force-pushed the marcsanmi/add-enable-symbolizer-overrides branch from 63b5bd3 to 4fd10f4 Compare April 25, 2025 13:30
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you for your patience – and sorry for the many notes!

@marcsanmi marcsanmi merged commit 1ca0b6b into marcsanmi/symbolization-poc Apr 29, 2025
20 checks passed
@marcsanmi marcsanmi deleted the marcsanmi/add-enable-symbolizer-overrides branch April 29, 2025 11:25
marcsanmi added a commit that referenced this pull request May 7, 2025
* feat: add symbolizer per tenant overrides
marcsanmi added a commit that referenced this pull request May 8, 2025
* feat: add symbolizer per tenant overrides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants