Stringify path if Rails version > 7 #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling recognize_path with a path that is a symbol will result in a: ``` NoMethodError: undefined method `include?' for an instance of Symbol ``` This results in a nil value being returned which leads to this error for the developer: ``` Graphiti::Errors::InvalidLink: Api::V2::GymResource: Cannot link to sideload :my_resource! Make sure the endpoint "/api/v2/my_resource" exists with action :index, or customize the endpoint for Api::V2::MyResource. If you do not wish to generate a link, pass link: false or set self.autolink = false. ```
|
@sideshowbandana I changed jobs a while back and am no longer working with Rails. If you, or anyone you know, are interested in helping maintain this project please let me know. |
|
@wagenet , sorry to interrupt your discussion but wanted to ask whether you mean interested in maintaining this particular gem or the whole Graphiti project? |
|
👍 |
|
@sideshowbandana Thanks for the PR. I've been the skeleton crew maintaining graphiti for the past year, but I'm still waiting on getting access to this gem, so I can't cut a new release quite yet. But I'm working on it. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
## [0.4.1](v0.4.0...v0.4.1) (2025-03-21) ### Bug Fixes * `register_parameter_parser` overiding custom config ([#109](#109)) ([a135bfa](a135bfa)) * Add basic column type conversion. ([#83](#83)) ([e5bbc92](e5bbc92)) * Add condition to check RSpec availability in install generator ([#63](#63)) ([13895d9](13895d9)) * rspec double was leaking across tests ([#105](#105)) ([b38faf2](b38faf2)) * Stringify path if Rails version > 7 ([#107](#107)) ([47d356c](47d356c))
|
🎉 This PR is included in version 0.4.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling recognize_path with a path that is a symbol will result in a:
This results in a nil value being returned which leads to this error for the developer: